Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-3788] allow special characters in tab names #8660

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

zzhaobraze
Copy link
Collaborator

@zzhaobraze zzhaobraze commented Dec 19, 2024

Why are you making this change? (required)

Currently, tabs break and display no content if you use special characters (such as .) in a tab name. This is an issue because some tabs that reference filenames (like in the following example), will break. Here's a tab from Other SDK customizations for Android and FireOS, that will currently break when selected:

{% tab Braze.xml %}

Application tab:

Screen Shot 2024-12-23 at 10 27 47 AM

Braze.xml tab:

Screen Shot 2024-12-23 at 10 27 40 AM

Related PRs, issues, or features (optional)

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tested several languages locally.

@internetisaiah internetisaiah merged commit 2c16aa9 into develop Dec 23, 2024
7 checks passed
@internetisaiah internetisaiah deleted the adjust-tab-function branch December 23, 2024 18:28
@internetisaiah internetisaiah changed the title normalize tab names better [BD-3788] allow special characters in tab names Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants